Skip to content

[BUGFIX] Parse @font-face src property as comma-delimited list #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

[BUGFIX] Parse @font-face src property as comma-delimited list #794

merged 1 commit into from
Jan 19, 2025

Conversation

oliverklee
Copy link
Collaborator

Fixes #789.

Also adds an initial TestCase for Rule/Rule.

This is the 8.x backport of #790.

@oliverklee oliverklee added this to the 8.8.0 milestone Jan 19, 2025
@oliverklee oliverklee self-assigned this Jan 19, 2025
@oliverklee oliverklee marked this pull request as draft January 19, 2025 09:40
@oliverklee oliverklee force-pushed the backport/src-property branch from 95e16b7 to 45ced32 Compare January 19, 2025 09:47
@oliverklee oliverklee added the blocked Needs another issue to be resolved first label Jan 19, 2025
@oliverklee
Copy link
Collaborator Author

blocked by #796

@JakeQZ @oliverklee
[BUGFIX] Parse @font-face src property as comma-delimited list
719e2ef 
Fixes #789.

Also adds an initial `TestCase` for `Rule/Rule`.

This is the 8.x backport of #790.
@oliverklee oliverklee force-pushed the backport/src-property branch from 45ced32 to 719e2ef Compare January 19, 2025 20:50
@oliverklee oliverklee removed the blocked Needs another issue to be resolved first label Jan 19, 2025
@oliverklee oliverklee marked this pull request as ready for review January 19, 2025 20:51
@oliverklee oliverklee requested a review from JakeQZ January 19, 2025 20:51
JakeQZ
JakeQZ approved these changes Jan 19, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WD.

tests/Unit/Rule/RuleTest.php
$actualClassnames = \array_map(
/**
* @param Value|string $component
* @return string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a feeling that we may not be able to use some type hints in backports, so feel vindicated re #790 (comment) :)

@JakeQZ JakeQZ merged commit 6f37a7a into v8.x Jan 19, 2025
25 checks passed
@JakeQZ JakeQZ deleted the backport/src-property branch January 19, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
backport bug
Projects
None yet
Milestone
8.8.0: Deprecate and replace some API...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ